fix: save secret key per form with useQuery to prevent need for entering secret key #5743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justynoh
reviewed
Feb 13, 2023
There was a problem hiding this comment.
Thanks for the contribution @darrelhong ! Just one small comment. Additionally, there's a linter warning - would you be able to fix it? thanks!
frontend/src/features/admin-form/responses/ResponsesPage/storage/useSecretKey.ts
Outdated
Show resolved
Hide resolved
darrelhong
force-pushed
the
fix/save-secret-key
branch
from
23bf6d3 to
2e3bc7b
Compare
feature parity with angular
darrelhong
force-pushed
the
fix/save-secret-key
branch
from
2e3bc7b to
236c76f
Compare
justynoh
approved these changes
Feb 16, 2023
|
Closing and reopening to try and get tests to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users need to key in secret key each time they exit the form. PR also serves to achieve feature parity with angular
Closes #5514
Solution
use useQuery to store secretKey per form. Maintained signature of secretKey and setSecretKey in
useSecretKeys.tsfor minimal code change. queryFn resolves to string for type inference. Set stale time to infinity so that queryFn is never called again, resetting secretKey.cc @amitogp @kennethchangOPENGOV
Breaking Changes