Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: merge Release 4.42.0 into master #528

Merged
merged 19 commits into from
Nov 2, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
32f4dc0
chore(deps-dev): bump ts-jest from 26.3.0 to 26.4.1 (#496)
dependabot[bot] Oct 20, 2020
8476a17
docs(readme): acknowledge TellForm, others (#495)
LoneRifle Oct 20, 2020
6c499f4
fix(deps): bump angular-sanitize from 1.8.0 to 1.8.1 (#494)
dependabot[bot] Oct 20, 2020
7d62933
Merge pull request #497 from opengovsg/release-4.41.0
mantariksh Oct 21, 2020
48f9035
fix(deps): bump selectize from 0.12.4 to 0.12.6 (#500)
dependabot[bot] Oct 21, 2020
24e7700
chore(deps-dev): bump @typescript-eslint/parser from 4.0.1 to 4.5.0 (…
dependabot[bot] Oct 22, 2020
5844618
fix(deps): bump mongoose from 5.10.0 to 5.10.9 (#449)
dependabot[bot] Oct 22, 2020
a6ac8ef
build: revert "fix(deps): bump mongoose from 5.10.0 to 5.10.9"
liangyuanruo Oct 22, 2020
4fe70de
build: pin mongoose version to 5.10.0 (#504)
liangyuanruo Oct 22, 2020
1d3213a
feat: require non-empty domains if restrict domain is toggled on (#507)
karrui Oct 26, 2020
5715eac
fix(deps): unpin and bump mongoose from 5.10.0 to 5.10.10 (#513)
karrui Oct 26, 2020
9823124
feat: log create form failure on GA (#505)
tshuli Oct 26, 2020
ef537eb
chore: fix node version used to 12.18.4 to be consistent (#516)
karrui Oct 27, 2020
8fc2f24
chore(deps-dev): bump jasmine from 3.6.1 to 3.6.2 (#508)
dependabot[bot] Oct 27, 2020
ce99ac0
chore(deps-dev): bump ts-node-dev from 1.0.0-pre.49 to 1.0.0 (#510)
dependabot[bot] Oct 27, 2020
455b380
fix(deps): bump twilio from 3.49.3 to 3.50.0 (#479)
dependabot[bot] Oct 27, 2020
c7edb6e
chore: bump version to v4.42.0
tshuli Oct 27, 2020
6b3348e
fix: disable restrict email domains toggle if no otp verification
tshuli Oct 27, 2020
65a5567
Merge pull request #519 from opengovsg/release-4.42.0-hotfix
tshuli Oct 27, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,31 @@ All notable changes to this project will be documented in this file. Dates are d

Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).

#### [v4.42.0](https://github.com/opengovsg/FormSG/compare/v4.41.0...v4.42.0)

- fix(deps): bump twilio from 3.49.3 to 3.50.0 [`#479`](https://github.com/opengovsg/FormSG/pull/479)
- chore(deps-dev): bump ts-node-dev from 1.0.0-pre.49 to 1.0.0 [`#510`](https://github.com/opengovsg/FormSG/pull/510)
- chore(deps-dev): bump jasmine from 3.6.1 to 3.6.2 [`#508`](https://github.com/opengovsg/FormSG/pull/508)
- chore: fix node version used to 12.18.4 to be consistent [`#516`](https://github.com/opengovsg/FormSG/pull/516)
- feat: log create form failure on GA [`#505`](https://github.com/opengovsg/FormSG/pull/505)
- fix(deps): unpin and bump mongoose from 5.10.0 to 5.10.10 [`#513`](https://github.com/opengovsg/FormSG/pull/513)
- feat: require non-empty domains if restrict domain is toggled on [`#507`](https://github.com/opengovsg/FormSG/pull/507)
- build: pin mongoose version to 5.10.0 [`#504`](https://github.com/opengovsg/FormSG/pull/504)
- fix(deps): bump mongoose from 5.10.0 to 5.10.9 [`#449`](https://github.com/opengovsg/FormSG/pull/449)
- chore(deps-dev): bump @typescript-eslint/parser from 4.0.1 to 4.5.0 [`#501`](https://github.com/opengovsg/FormSG/pull/501)
- fix(deps): bump selectize from 0.12.4 to 0.12.6 [`#500`](https://github.com/opengovsg/FormSG/pull/500)
- build: merge Release 4.41.0 into develop [`#497`](https://github.com/opengovsg/FormSG/pull/497)
- fix(deps): bump angular-sanitize from 1.8.0 to 1.8.1 [`#494`](https://github.com/opengovsg/FormSG/pull/494)
- docs(readme): acknowledge TellForm, others [`#495`](https://github.com/opengovsg/FormSG/pull/495)
- chore(deps-dev): bump ts-jest from 26.3.0 to 26.4.1 [`#496`](https://github.com/opengovsg/FormSG/pull/496)
- build: revert "fix(deps): bump mongoose from 5.10.0 to 5.10.9" [`a6ac8ef`](https://github.com/opengovsg/FormSG/commit/a6ac8ef67dbdaefbab0a1fecc1173fc4f6a70399)
- fix: use mobile view for submission search / filter elements up till xl [`058ab66`](https://github.com/opengovsg/FormSG/commit/058ab6624431e88da6253b481246e44fbb920be4)
- fix: missing period for decryption modal [`36c24e7`](https://github.com/opengovsg/FormSG/commit/36c24e7b46ca3f7b0f4743296e8ef65778490181)

#### [v4.41.0](https://github.com/opengovsg/FormSG/compare/v4.40.0...v4.41.0)

> 20 October 2020

- feat: allow form transfer for email mode forms [`#488`](https://github.com/opengovsg/FormSG/pull/488)
- chore(deps-dev): bump husky from 4.2.5 to 4.3.0 [`#480`](https://github.com/opengovsg/FormSG/pull/480)
- refactor: use celebrate error handler [`#458`](https://github.com/opengovsg/FormSG/pull/458)
Expand All @@ -27,6 +50,7 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
- fix(deps): bump validator from 13.1.1 to 13.1.17 [`#463`](https://github.com/opengovsg/FormSG/pull/463)
- fix(deps): bump angular-resource from 1.8.0 to 1.8.1 [`#464`](https://github.com/opengovsg/FormSG/pull/464)
- chore: merge release v4.40.0 back into develop [`#462`](https://github.com/opengovsg/FormSG/pull/462)
- chore: bump version to 4.41.0 [`21a01d7`](https://github.com/opengovsg/FormSG/commit/21a01d71d90aed613f05df7a598b5673baec08f5)

#### [v4.40.0](https://github.com/opengovsg/FormSG/compare/v4.39.0...v4.40.0)

Expand Down
16 changes: 16 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -192,3 +192,19 @@ We welcome all contributions, bug reports, bug fixes, documentation improvements
## Support

Please contact FormSG ([email protected]) for any details.

## Acknowledgements

FormSG acknowledges the work done by [Arielle Baldwynn](https://github.com/whitef0x0) to build and maintain [TellForm](https://github.com/tellform), on which FormSG is based.

Contributions have also been made by:
[@RyanAngJY](https://github.com/RyanAngJY)
[@jeantanzy](https://github.com/jeantanzy)
[@yong-jie](https://github.com/yong-jie)
[@pregnantboy](https://github.com/pregnantboy)
[@namnguyen08](https://github.com/namnguyen08)
[@zioul123](https://github.com/zioul123)
[@JoelWee](https://github.com/JoelWee)
[@limli](https://github.com/limli)
[@tankevan](https://github.com/tankevan)
[@LoneRifle](https://github.com/LoneRifle)
3 changes: 2 additions & 1 deletion docs/TROUBLESHOOTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@ A list of common issues that developers face and how to resolve them.
## `Error: Module did not self-register.`

This could happen if node modules were compiled with a different version of node, or if node modules fail to compile due to other configuration errors.
Running tests locally requires `node` to specifically be of version `12.18.4`. You can use `nvm` to manually set the node version.

### [Node Versioning Error](https://stackoverflow.com/questions/28486891/uncaught-error-module-did-not-self-register)

Run the following commands to set the node version and then re-install the node modules:

```
nvm use 12.18.0
nvm use 12.18.4
rm -r node_modules
npm install
```
Expand Down
Loading