Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(v2): misc build pipeline updates in preparation for merging into main branch #5010

Merged
merged 6 commits into from
Oct 5, 2022
Merged

chore(v2): misc build pipeline updates in preparation for merging into main branch #5010

merged 6 commits into from
Oct 5, 2022

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Oct 4, 2022

Problem

This PR updates our GitHub Action workflows to be compatible with develop branch.

This includes:

  • Fixing an uncaught broken test on AngularJS due to React changes (and not running AngularJS tests on form-v2/** branches)
  • Letting Chromatic run on all branches
  • Updating test and e2e scripts to run properly once merged in
  • Updating React specific ci/cd to run on develop (all branches actually)
  • Updating insecure packages that Snyk has flagged out.

After this PR is merged in, we can then proceed to merge form-v2/develop into develop.

@karrui karrui changed the title chore: misc build pipeline updates in preparation for merging into main branch chore(v2): misc build pipeline updates in preparation for merging into main branch Oct 4, 2022
@karrui
Copy link
Contributor Author

karrui commented Oct 4, 2022

All checks passed!

justynoh
justynoh approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@justynoh justynoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karrui karrui merged commit 40331be into form-v2/develop Oct 5, 2022
@karrui karrui deleted the form-v2/preparation-for-develop-merge branch October 5, 2022 01:58
@karrui karrui mentioned this pull request Oct 5, 2022
Merged
@justynoh justynoh mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justynoh justynoh justynoh approved these changes

@wanlingt wanlingt Awaiting requested review from wanlingt

@timotheeg timotheeg Awaiting requested review from timotheeg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karrui @justynoh