fix(v2): allow maximum rows for table fields to be optional #4945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
approved these changes
Sep 27, 2022
...der-and-design/BuilderAndDesignDrawer/EditFieldDrawer/edit-fieldtype/EditTable/EditTable.tsx
Show resolved
Hide resolved
wanlingt
approved these changes
Sep 27, 2022
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previous version of the app allows users to not add a maximum number of rows, resulting in unlimited rows being able to be added. React did not have this feature.
Closes #4935
Solution
Remove requiredness for max rows in edit table, update associated components and handlers to manage this possibility.
Breaking Changes
Screenshots
Admin form
Screen.Recording.2022-09-27.at.1.03.47.AM.mov
Public form
Screen.Recording.2022-09-27.at.1.05.14.AM.mov