Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): read out submission confirmation for screen readers on success #4917

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Sep 21, 2022

Problem

Currently, screen reader users do not know when their form has been submitted. This PR adds an aria-live region where success state is being read out on submission success.

Closes #4179 #4189

Solution

Breaking Changes

  • No - this PR is backwards compatible

Copy link
Contributor

@justynoh justynoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants