-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): enable refetch on mount for storage responses #4821
feat(v2): enable refetch on mount for storage responses #4821
Conversation
… table headers and searchbox
As for why 10s, we can look at some logs for reference. Not sure if this is super useful but also i figured i can just look at it to brush up on my cloudwatch syntax anyway ¯_(ツ)_/¯ Ran these queries at 11:07am on a Thursday over 3 hours, thus capturing logs from 8-11am on a weekday (our busiest traffic period). The highest form got 980 submissions over 3h, which amounts to about 980/(3*60) = 5.44 submissions per minute, on average, so 10s is more than sufficient to update fast enough. Looking from the admin perspective, we can find how many admins are interested in their storage submission metadata. In the same time period we can look at what's the first and last request for each form (duration is the time between the first and last request), and how many requests they made within that time period. The maximum number of requests made was 293 in 3 hours, but that was within the span of about an hour. The remainder all made less than 100 requests. The duration was varying, though. This is very coarse-grained data, if we really want to know, we can look deeper into those who seemed to be "online" for a long time (e.g. for almost the whole 3h period) to determine what their usage patterns are. |
should we also update the PR description? |
Problem
Storage responses was not refetching until the admin refreshed the page. But once they refresh the page, they need to upload their secret key again, creating higher friction for admins to see their updated form responses.
Closes #4737
Solution
Remove custom refetch settings.
Also made some changes to the storage responses page for mobile responsiveness.
Breaking Changes
Screenshots
Screen.Recording.2022-09-08.at.5.07.28.PM.mov