Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(v2): remove partytown #4816

Merged
merged 2 commits into from
Sep 8, 2022
Merged

chore(v2): remove partytown #4816

merged 2 commits into from
Sep 8, 2022

Conversation

wanlingt
Copy link
Contributor

@wanlingt wanlingt commented Sep 7, 2022

Problem

We no longer use partytown to load Google Analytics 4 (related to #4665)

Solution

Remove partytown.

We can explore re-enabling partytown with GA4 when we look into optimising our deployment pipeline.

@wanlingt wanlingt requested review from timotheeg and karrui September 7, 2022 09:11
timotheeg
timotheeg approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@timotheeg timotheeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - verified partytown is removed:

$ git grep -i partytown | wc -l
       0

@wanlingt wanlingt merged commit 0d84c1c into form-v2/develop Sep 8, 2022
@wanlingt wanlingt deleted the form-v2/remove-partytown branch September 8, 2022 02:06
This was referenced Oct 4, 2022
Closed
Merged
@justynoh justynoh mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeg timotheeg timotheeg approved these changes

@karrui karrui Awaiting requested review from karrui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanlingt @timotheeg