feat(v2): add navigation prompt modal when navigating away during submission download #4794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
deleted the
form-v2/show-navigation-prompt-on-waiting-download
branch
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR adds a modal that appears when a form admin attempts navigation (unmounting the download progress component) during a form download.
Also fixes a bug where the progress modal can be closed by the escape key. This should not happen and users should not be able to close the modal during downloads.
Closes #4144
Solution
Breaking Changes
Features:
usePrompthook withNavigationPromptcomponentBug Fixes:
Before & After Screenshots