fix(v2): fix render bug in delete field modal, misc builder improvements #4791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
DeleteFieldModal
,BuilderAndDesignTab
modified to fix render bugs by rendering modal only when deleteFieldModalDisclosure is open.FieldRowContainer
now hides draggable iconEditParagraph
field name is now ParagraphEditMyInfo
only renders the drawer footer if creating, otherwise no footer is shown. Additionally, fixed a small bug withDrawerContentContainer
which dividers to show in betweennull
orundefined
children (which was necessary in this case).CreatePageSidebarContext
>setActiveOrPendingTab
always sets to inactive field if creation is cancelled, regardless of mobile or desktop.VerifiedFieldBuilderContainer
which wraps verified input fields with the builder button (which will be always disabled, as confirmed by @pearlyong). Use it inFieldRowContainer
to wrap mobile and email fields if verified, a laFieldFactory
.Breaking Changes