Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix render bug in delete field modal, misc builder improvements #4791

Merged
merged 3 commits into from
Sep 5, 2022

Conversation

justynoh
Copy link
Contributor

@justynoh justynoh commented Sep 5, 2022

Problem

  1. Delete field modal had a render bug (question numbers were not calculated correctly due to modal rendering on builder open rather than delete field button onClick). Also, trying to create fields crashes. oops.
  2. Hide draggable icon when field is in creating state, closes [0.5] Draggable icon should not be displayed if field is in Creating state #4657
  3. Rename statement to paragraph in Edit Paragraph drawer, closes Rename statement to paragraph #4751
  4. Remove "Save field" footer from MyInfo edit drawers, closes Remove "Save field" footer from MyInfo fields edit drawer #4741
  5. Do not retain create fields in mobile, closes [2] bug: Pressing close button on create field in mobile should discard the field instead of keeping field around #4729
  6. Verify button should be displayed for verified fields in the builder, closes Display verification button for verified fields in the builder #4739

Solution

  1. DeleteFieldModal, BuilderAndDesignTab modified to fix render bugs by rendering modal only when deleteFieldModalDisclosure is open.
  2. FieldRowContainer now hides draggable icon
  3. EditParagraph field name is now Paragraph
  4. EditMyInfo only renders the drawer footer if creating, otherwise no footer is shown. Additionally, fixed a small bug with DrawerContentContainer which dividers to show in between null or undefined children (which was necessary in this case).
  5. CreatePageSidebarContext > setActiveOrPendingTab always sets to inactive field if creation is cancelled, regardless of mobile or desktop.
  6. Add VerifiedFieldBuilderContainer which wraps verified input fields with the builder button (which will be always disabled, as confirmed by @pearlyong). Use it in FieldRowContainer to wrap mobile and email fields if verified, a la FieldFactory.

Breaking Changes

  • No - this PR is backwards compatible

@justynoh justynoh marked this pull request as ready for review September 5, 2022 06:29
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justynoh justynoh merged commit 1b4af3f into form-v2/develop Sep 5, 2022
@justynoh justynoh deleted the form-v2/feat/misc-builder-improvements branch September 5, 2022 09:13
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants