Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-v2): add http protocol #4779

Merged
merged 1 commit into from
Aug 31, 2022
Merged

fix(form-v2): add http protocol #4779

merged 1 commit into from
Aug 31, 2022

Conversation

tohhengxing
Copy link
Contributor

Problem

redirect button should accept http.

closes #4754

Solution

add protocol and update error message

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

AFTER:

issue-4754-after-fix.mp4

Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karrui karrui merged commit afd8f2f into opengovsg:form-v2/develop Aug 31, 2022
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants