feat(v2): prevent attachment field duplication if size limit exceeded, add toasts for duplication #4699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded, toasts for duplication
|
Actually, our backend should also probably validate the dupe request as well to ensure that it's valid. Might want to implement that to |
karrui
approved these changes
Aug 29, 2022
.../admin-form/create/builder-and-design/BuilderAndDesignContent/FieldRow/FieldRowContainer.tsx
Outdated
Show resolved
Hide resolved
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Attachment fields can be duplicated even if the size limit ends up being exceeded which is a bug. In Angular, a modal pops up showing that the attachment can't be duplicated.
Simultaneously, found a difference between angular and react in that we don't notify users when logiced fields are duplicated. Added as part of the toast, as agreed on slack.
Closes #4648
Solution
a. In field row container, add check prior to dupe.
b. Factor out function getting max attachment size.
logicedFieldIdsSetto admin form logic, and access it in order to determine whether to show logic sentence in dupe toast.Breaking Changes
Screenshots
Screen.Recording.2022-08-26.at.6.28.59.PM.mov