fix: add navbar to billing page, fix misc css issues, modal popout conditionals #4685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of landing page route. Since this is the admin nav bar, probably makes more sense to use root route instead so users can go back whenever.
localstorage retrieval takes time, and undefined value will just open the modal. Set to false on default instead and check for presence.
fixes console error
justynoh
approved these changes
Aug 26, 2022
wanlingt
reviewed
Aug 26, 2022
qin-guan
reviewed
Aug 26, 2022
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR adds the navbar to the admin billing page. Also updates admin navbar logo to link to the dashboard instead of the landing page.
Also fixes a bunch of react errors that were popping out on the console, such as
also updates conditional to determine when the emergency contact or rollout modals popped out.
Closes #4646