fix: set addMoreFields derived value so useEffect is stable #4669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
would throw a console error when any values for editing table fields are changed. This commit correctly sets the initial value of the addMoreRows toggle when nextMaxRows is set Error thrown: "The final argument passed to useEffect changed size between renders. The order and size of this array must remain constant."
justynoh
approved these changes
Aug 23, 2022
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
would throw a console error when any values for editing table fields are changed.
This commit correctly sets the initial value of the addMoreRows toggle when nextMaxRows is set
Error thrown: "The final argument passed to useEffect changed size between renders. The order and size of this array must remain constant."