Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: copy changes #4664

Merged
merged 3 commits into from
Sep 5, 2022
Merged

chore: copy changes #4664

merged 3 commits into from
Sep 5, 2022
+7 −17

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Aug 23, 2022 •
edited
Loading

Problem

Screenshots for #4642

  • Before:

Screenshot 2022-08-23 at 9 07 56 AM

Screenshot 2022-08-23 at 9 06 25 AM

  • After:

Screenshot 2022-08-23 at 9 00 47 AM

Screenshot 2022-08-23 at 9 05 57 AM

@tshuli tshuli changed the title chore: copy changes for toast chore: copy changes Aug 23, 2022
justynoh
justynoh approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@justynoh justynoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

frontend/src/features/login/components/OtpForm.tsx Show resolved Hide resolved
@timotheeg
Copy link
Contributor

@tshuli can we merge this?

@tshuli
Copy link
Contributor Author

tshuli commented Sep 5, 2022

@timotheeg yes, thanks! was pending design review previously which has now been approved.

@tshuli tshuli merged commit d0baf32 into form-v2/develop Sep 5, 2022
@tshuli tshuli deleted the form-v2/chore/copy-changes-toast branch September 5, 2022 02:01
This was referenced Oct 4, 2022
Closed
Merged
@justynoh justynoh mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justynoh justynoh justynoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tshuli @timotheeg @justynoh