Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): bunch of fixes in admin builder styling #4605

Merged
merged 8 commits into from
Aug 22, 2022

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Aug 19, 2022

Problem

This PR started off cleaning up webhook infomessage mislayout in admin form builder's edit endpage view.
But found a bunch of places where things could be improved and made those fixes after all.

Solution

Breaking Changes

  • No - this PR is backwards compatible

Features:

  • feat(Radio): add allowDeselect prop so users can set radio deselection
    • allows prevention of radio deselection in places where we do not need deselection (start page logo type, theme color, etc)

Improvements:

  • feat: update focus styling when start page is being edited
  • feat: update theme color radio styling to be more canonical
  • feat(EditEndPage): add pending update handling
  • feat: add image fallback handling for startpage

Bug Fixes:

  • fix: move webhook info message to BuilderAndDesignContent for correct layout due to flex direction
  • fix: prevent file selection window from opening on logo label click

Before & After Screenshots

Should be updated

@karrui karrui requested a review from justynoh August 22, 2022 02:25
@karrui karrui merged commit 197cc31 into form-v2/develop Aug 22, 2022
@karrui karrui deleted the form-v2/fix-admin-builder-styling branch August 22, 2022 05:58
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants