feat(v2): add and use NavigationTabs template components for admin form tab navigation #4601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of Tab component was messing with the navigation prompt, since the Tab component's tab index onChange callback will fire continuously even if user dismisses the prompt. This was a really hard bug to drill down to...
so the NavigationTab component has full height
karrui
changed the title
karrui
changed the title
no need, users should be able to navigate regardless
correctly prefixing the routes in affected stories
1 task
justynoh
approved these changes
Aug 23, 2022
frontend/src/features/admin-form/common/components/AdminFormNavbar/AdminFormNavbar.tsx
Show resolved
Hide resolved
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR updates the components used for navigation from ChakraUI tabs to a faux tab component meant to be used for links.
This component fixes a bug where the blocking of navigation would fail (infinite loop) until user accepts the navigation block. That was due to ChakraUI's
Tabcomponent retriggering itsonChangecallback continuously (which retriggers navigation, which retriggers the block).By using real links instead of the Tab component, no
react-router-dom#navigatecall is called and users can safely accept/reject the prompt.Related to #4144
Solution
Breaking Changes
Features:
Before & After Screenshots
Should have absolutely no visual changes