feat(v2): add loading screens for logic tab and results page #4579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantariksh
approved these changes
Aug 15, 2022
frontend/src/features/admin-form/create/logic/components/EmptyLogic.tsx
Outdated
Show resolved
Hide resolved
karrui
reviewed
Aug 16, 2022
frontend/src/features/admin-form/create/logic/components/EmptyLogic.tsx
Outdated
Show resolved
Hide resolved
karrui
reviewed
Aug 16, 2022
frontend/src/features/admin-form/responses/ResponsesPage/ResponsesPageSkeleton.tsx
Show resolved
Hide resolved
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are loading states in the logic tab and results page files that have not been created. This PR implements the loading states for those files in line with documentation on Figma (see the issue).
Closes [#4573 ]
Solution
Add loading states and corresponding stories.
Breaking Changes