Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): always enable e-service id box in auth settings #4576

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

justynoh
Copy link
Contributor

@justynoh justynoh commented Aug 15, 2022

Problem

Currently, the e-service id box is disabled when the form is open and when myinfo fields are present. We want the e-service id box to be enabled.

Closes [#4540 ]

Solution

Change the isDisabled prop passed to the e-service ID Box.

Breaking Changes

  • No - this PR is backwards compatible

Screenshot

image

@justynoh justynoh marked this pull request as ready for review August 15, 2022 05:55
@wanlingt wanlingt self-requested a review August 15, 2022 06:53
Copy link
Contributor

@wanlingt wanlingt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justynoh justynoh merged commit b38db39 into form-v2/develop Aug 24, 2022
@justynoh justynoh deleted the form-v2/fix/auth-esrvcid branch August 24, 2022 06:41
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants