fix(form-v2): refactor to avoid repopulating design store when cache is invalidated #4554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er to ensure no overwrites when form is refetched
karrui
approved these changes
Aug 15, 2022
| export const DesignDrawer = ({ | ||
| startPageData, | ||
| }: DesignDrawerProps): JSX.Element | null => { | ||
| export const DesignInput = (): JSX.Element | null => { |
There was a problem hiding this comment.
nit: should this be extracted to its own component?
There was a problem hiding this comment.
we could but i don't think it's really necessary, DesignInput isn't reusable in any way (unlike, for instance, EditFieldContainer which can take in various Edit<X> as children)
| @@ -183,6 +191,203 @@ export const DesignDrawer = ({ | |||
|
|
|||
| if (!startPageData) return null | |||
|
|
|||
| return ( | |||
| <DrawerContentContainer> | |||
There was a problem hiding this comment.
i assume this is a pure movement of code and has no changes from the previous implementation
Comment on lines
378
to
379
| if (startPage.logo.state === FormLogoState.Custom) | ||
| setCustomLogoMeta(startPage.logo) |
There was a problem hiding this comment.
nit: can multiline conditionals be wrapped in braces for consistency in the codebase plsssssss
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the current implementation, design store contents is reset to the original server state upon cache invalidation. Rather, we should retain the existing design store contents.
The reason why this occurs in the current implementation is that the effect in
DesignDrawerContaineris run once upon invalidation (with an empty form), and then once again once the form is refetched (thus repopulating the design store with the server data).Closes [#4547 ]
Solution
Move the population of design store with server state data from
DesignDrawerContainerintoDesignDrawer, which now wrapsDesignInput. Thus, when the cache is invalidated and the form is refetching, we don't even render the design drawer, which means we also don't re-run the effect to repopulate the store.Breaking Changes
Screenshots
Screen.Recording.2022-08-11.at.4.32.37.PM.mov