feat: add info banner to admin form builder when webhooks are enabled #4551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will wait for #4525 to go in first before I reopen this... if not rebase hell again |
karrui
force-pushed
the
form-v2/fix-issue-3954
branch
from
0b182b8 to
ea922f0
Compare
karrui
commented
Aug 16, 2022
Comment on lines
60
to
65
| {settings?.webhook?.url ? ( | ||
| <Banner showCloseButton={false}> | ||
| Webhooks are enabled on this form. Please ensure the webhook server is | ||
| able to handle any field changes. | ||
| </Banner> | ||
| ) : null} |
There was a problem hiding this comment.
added new box and the banner here. all other layout stayed the same
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #3954