Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form-v2/react-to-angular/3): remove infoboxes when rollout percentages hit thresholds #4514

Merged
merged 5 commits into from
Aug 10, 2022

Conversation

wanlingt
Copy link
Contributor

@wanlingt wanlingt commented Aug 5, 2022

Solution

Remove visibility of switch-back-to-AngularJS infoboxes after rollouts hit their respective % (10% for public respondents, 100% for admins)

Closes #3933

Details

  • Add
    respondentRolloutEmail, respondentRolloutStorage, adminRollout to frontend end vars
  • Determine showSwitchEnvMessage boolean depending on whether the rollout % > the % threshold to remove the infobox

Breaking Changes

  • No - this PR is backwards compatible

Tests

  • Set the rollout % for an email mode form below the % threshold for removal of the infobox. Infobox should be visible.
  • Set the rollout % for a storage mode form below the % threshold for removal of the infobox. Infobox should be visible.
  • Set the rollout % for admins below the % threshold for removal of the infobox. Infobox should be visible.
  • Repeat the 3 tests above, but set the rollout % to be above the % threshold for removal of the infobox. The infobox should no longer be seen.

@wanlingt wanlingt marked this pull request as draft August 5, 2022 10:04
@wanlingt wanlingt changed the title feat(form-v2/react-to-angular/3): remove infoboxes when rollout percentages hit thresholds WIP feat(form-v2/react-to-angular/3): remove infoboxes when rollout percentages hit thresholds Aug 5, 2022
@wanlingt wanlingt changed the title WIP feat(form-v2/react-to-angular/3): remove infoboxes when rollout percentages hit thresholds [WIP] feat(form-v2/react-to-angular/3): remove infoboxes when rollout percentages hit thresholds Aug 5, 2022
@wanlingt wanlingt changed the title [WIP] feat(form-v2/react-to-angular/3): remove infoboxes when rollout percentages hit thresholds feat(form-v2/react-to-angular/3): remove infoboxes when rollout percentages hit thresholds Aug 8, 2022
@wanlingt wanlingt marked this pull request as ready for review August 8, 2022 01:13
@timotheeg timotheeg self-requested a review August 8, 2022 06:22
Copy link
Contributor

@timotheeg timotheeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wanlingt wanlingt merged commit 3f6cd3a into form-v2/develop Aug 10, 2022
@wanlingt wanlingt deleted the form-v2/react-to-angular-3 branch August 10, 2022 08:05
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants