feat(form-v2): set opacity for fields hidden by logic in builder #4482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justynoh
changed the title
timotheeg
reviewed
Aug 4, 2022
.../admin-form/create/builder-and-design/BuilderAndDesignContent/FieldRow/FieldRowContainer.tsx
Outdated
Show resolved
Hide resolved
justynoh
changed the title
…at/builder-fields-hidden
timotheeg
reviewed
Aug 8, 2022
| <Tooltip | ||
| hidden={!isHiddenByLogic} | ||
| placement="top" | ||
| label="This field may be hidden by your form logic" |
There was a problem hiding this comment.
may be or is? Asking because the Tooltip's only control on its hidden state is isHiddenByLogic 🤔
There was a problem hiding this comment.
hahah. this was the copy that was agreed upon. In actual fact, the field is hidden by logic by default (i.e. on first load of the form). Could change the variable name to isDefaultHiddenByLogic if that feels better?
There was a problem hiding this comment.
Nah, let's keep it. We can revisit later if needed.
There was a problem hiding this comment.
may is correct, since a logic match will show the field yea?
timotheeg
approved these changes
Aug 10, 2022
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fields hidden by default due to logic hiding are greyed out in the form builder in angular, but we don't show them as hidden in react.
Closes #4442
Solution
getVisibleFieldsIdfrom logic to determine which fields are displayed by default.Breaking Changes
Screenshots