Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: preload inter fonts from app directory in storybook preview-head #4458

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Aug 2, 2022

Problem

Trying this to further reduce flakiness in story by directly loading fonts used in the app before stories even gets rendered.

Solution

Improvements:

  • preload with app's font files instead of using Google Fonts.

@karrui karrui changed the title feat: preload inter fonts from app directory in storybook preview-head perf: preload inter fonts from app directory in storybook preview-head Aug 2, 2022
@karrui karrui merged commit 733d9ed into form-v2/develop Aug 2, 2022
@karrui karrui deleted the form-v2/preload-fonts-properly branch August 2, 2022 09:56
karrui added a commit that referenced this pull request Sep 14, 2022
karrui added a commit that referenced this pull request Sep 14, 2022
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants