fix: ensure admin builder page has overflow auto style for proper drawer scroll, update form view layout #4451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
something is injecting overflow='initial' into the component's styling, preventing the overflow state from being set...
|
reverting the change, will fix in future PR |
timotheeg
approved these changes
Aug 2, 2022
karrui
changed the title
|
pearly caught a regression,.. the padding change had to go out after all hehehe |
1 task
|
Some styling regressions, will draft while i fix them |
This was referenced Aug 5, 2022
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Something (something... i really can't find it in code) is injecting overflow='initial' into the component's styling, preventing the overflow state from being set...
This causes the 100% height drawer to be offset and thus will not be able to be scrolled to the bottom (since the real bottom is below the visible bottom)
This PR fixes that, and the drawer can be correctly scrolled now.
Closes #4305
Solution
Breaking Changes
Bug Fixes: