fix(form-v2): submit another form now returns to form page #4434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeg
reviewed
Aug 1, 2022
frontend/src/features/public-form/components/FormEndPage/components/EndPageBlock.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Timothee Groleau <[email protected]>
timotheeg
approved these changes
Aug 1, 2022
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Submit another form button leads to landing page
Closes [#4336 ]
Solution
removed faulty ?? operator
Breaking Changes
Bug Fixes:
a ?? bwill return a if a is not null or undefined.endPage.buttonLinkwas returning empty string if alternative link not provided hence giving unexpected behaviour as outlined underhttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing_operator
Before & After Screenshots
BEFORE:
issue_4336_before_fix.mp4
AFTER:
issue_4336_after_fix.mp4