Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated validation for others input in radio and checkbox to onl… #4402

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

justynoh
Copy link
Contributor

Problem

Currently, Radio and Checkbox "Others" input validates upon the "Others" option being selected. We only want to validate these on blur.

Closes #4379

Solution

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

Screen.Recording.2022-07-28.at.10.19.35.AM.mov

@justynoh justynoh requested a review from karrui July 28, 2022 02:24
Copy link
Contributor

@timotheeg timotheeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for adding the demo video!

@justynoh justynoh merged commit 0a42dda into form-v2/develop Jul 28, 2022
@justynoh justynoh deleted the form-v2/fix/others-validation branch July 28, 2022 09:09
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants