Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v2): redirect users to current browser link instead of homepage when prompting a refresh #4331

Merged
merged 1 commit into from
Jul 26, 2022
Merged

fix(v2): redirect users to current browser link instead of homepage when prompting a refresh #4331

merged 1 commit into from
Jul 26, 2022

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Jul 26, 2022 •
edited by wanlingt
Loading

Problem

3 locations were directing users to the home page instead of the intended refresh:

  1. When end page button link is not provided, the default behaviour should be to refresh the page to submit the form again.
  2. When form has changed and the toast prompts the user to refresh to fetch the latest changes in public form
  3. Above but for preview form (should not happen once Remove banner indicating changes have been made in Preview mode #4296 is closed, but including here for completeness)

Closes #4297, #4328

Solution

Breaking Changes

  • No - this PR is backwards compatible

Bug Fixes:

  • feat: use current location as href instead of empty string for link href props when directing to homepage is not desired (it probably never is)

@karrui
feat: use current location as href instead of empty string
229b829 
it directs users to root instead of the same page as should be expected
@karrui karrui requested review from justynoh and wanlingt July 26, 2022 04:24
wanlingt
wanlingt approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@wanlingt wanlingt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@karrui karrui merged commit 24d6d92 into form-v2/develop Jul 26, 2022
@karrui karrui deleted the form-v2/empty-link-redirection branch July 26, 2022 06:08
@karrui karrui mentioned this pull request Jul 26, 2022
Closed
This was referenced Oct 4, 2022
Closed
Merged
@justynoh justynoh mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanlingt wanlingt wanlingt approved these changes

@justynoh justynoh Awaiting requested review from justynoh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karrui @wanlingt