feat(form-v2/form-instructions-2): pull PublicSwitchEnvMessage into public form wrapper #4323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeg
approved these changes
Jul 27, 2022
| <InlineMessage variant="warning" mb="1.5rem" mt={{ base: '2rem', md: '0' }}> | ||
| <Text> | ||
| You’re filling this form on the new FormSG. If you have trouble | ||
| submitting,{' '} |
There was a problem hiding this comment.
Just checking: explicit space wasn't needed?
There was a problem hiding this comment.
oops that was my bad! I'll change it in my react-to-angular PR since it should apply to both PublicSwitchEnvMessage and AdminSwitchEnvMessage :)
1 task
justynoh
added a commit
that referenced
this pull request
Jul 28, 2022
* feat(form-v2/form-instructions-1): display instructions on public forms, admin builder and preview tool (#4306) * feat: display instructions on public form * feat: display instructions in builder and preview. * feat: pull PublicSwitchEnvMessage into PublicFormWrapper (#4323) * feat(form-v2/form-instructions-3): pull sidebar out into PublicFormWrapper and add instructions to sections sidebar (#4391) * feat: pull sidebar out to public form wrapper, update contexts to include instructions if it exists. added story for public form with instructions. * feat: added stories for preview and admin * chore: margin update for FormInstructions for mobile compatibility * feat: update preview form provider with instructions as well. * fix: add long instructions story, fix nits * feat: newline rendering for form instructions * feat: updates to stories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The react message currently shows up immediately before the form fields. However, we want this to be at the top of the form, immediately after the header. Moving it into the public form wrapper allows the message, form instructions and form fields to be displayed in the correct order.
Makes progress towards [#4236 ]
Solution
Breaking Changes