feat(v2): add handling of prefill for authed public forms, show fields correctly when logged in #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfi whether it actually works lol
might create a new hook to store query...
PublicFormProvider now uses useSearchParams hook, which requires memory router
timotheeg
reviewed
Jul 22, 2022
| // Do nothing if key is already query key. Might result in infinite loop if handled. | ||
| if (searchParams.get(REDIRECTED_QUERY_KEY)) return | ||
|
|
||
| const queryParams = Object.fromEntries([...searchParams]) |
There was a problem hiding this comment.
/superNit
Suggested change
| const queryParams = Object.fromEntries([...searchParams]) | |
| const queryParams = Object.fromEntries(searchParams.entries()) |
timotheeg
approved these changes
Jul 25, 2022
2 tasks
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR implements prefill for authenticatable public forms following AngularJS implementation in #3920.
Also contains a bug fix where form fields are still not shown when user is logged in.
Closes #3630
Solution
Breaking Changes
Features:
useStorePrefillQueryanduseFetchPrefillQueryhooksuseSessionStoragehook for session storage manipulationBug Fixes: