feat(form-v2/design-2): logo radio buttons and form color theme selection #4271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me and form instructions
…om public header for computation of design constants
…to reuse the same FormHeader and FormBannerLogo components.
…into form-v2/feat/builder-startpage
…at/builder-startpage
… so they can be easily reused.
…at/builder-startpage-2
…' into form-v2/feat/builder-startpage-2-new
timotheeg
reviewed
Jul 25, 2022
Comment on lines
+16
to
+20
| export type UploadedImage = { | ||
| file?: File | ||
| srcUrl?: string | ||
| } | ||
|
|
There was a problem hiding this comment.
I wonder if this type is descriptive enough 🤔? The definition allows a completely empty object, but is that really valid? Or is UploadedImage a union of 2 types, where at least one of the field is present in each?
There was a problem hiding this comment.
Should we can fix this in a separate PR? The type was originally Partial<{ file: File srcUrl: ImageFieldBase['url'] }> which this is equivalent to. But I agree that this type should be more restrictive. This fix would require edits to the startpage and editimage.
frontend/src/features/admin-form/create/builder-and-design/useDesignStore.tsx
Outdated
Show resolved
Hide resolved
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR implements the form logo uploader tool and color theme selection in the design drawer.
Makes progress towards #3362 and provides parity with angular.
Solution
Breaking Changes
Features:
FileHandlerService.ts,EditImage.tsx,UploadImageInput.tsxUploadedFileData.sizeinFileHandlerService.tsfromstringtonumber. As a result, moved stringification of size intoEditImage.tsxitself. (Necessary due toform.startPage.logo.fileSizeInBytesbeing of typenumber.)attachmenttype into its ownUploadedImagetype for reusability with design store.useFormHeader.tsxgetTitleBgfor reusability with design store.StartPageView.tsx,DesignDrawer.tsx,useDesignStore.tsxcustomLogoMeta.Before & After Screenshots
Notes