Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v2/storage): add download completion/cancelation modal screen #4142

Merged
merged 14 commits into from
Jul 20, 2022
Merged

feat(v2/storage): add download completion/cancelation modal screen #4142

merged 14 commits into from
Jul 20, 2022

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Jul 12, 2022 •
edited
Loading

Problem

This PR adds the completion or cancelation screens as denoted in design.

Closes #4141

Solution

Breaking Changes

  • No - this PR is backwards compatible

Features:

  • Allow clicking of export button even when response count is 0 for particular range
    • this allows a better UX where the reason for failure can be better shown to users, via:
      • warning toast when not downloading attachments,
      • warning info message in modal screen when attempting to download responses with attachments.
  • Show cancelation screen on cancelation when downloading with attachments
  • Show cancelation toast on cancelation when downloading without attachments
  • Show complete screen after decryption is complete when downloading with attachments
  • Show status toast with download status after decryption is complete when downloading without attachments

Before & After Screenshots

Stories have been added for the various states.

karrui added 12 commits July 7, 2022 14:11
@karrui
feat: allow clicking of export button when response count === 0
8df44a5 
so users can still trigger the respective options, just without any downloads
@karrui
feat: show warning info message when attemping to download 0 responses
669755f
@karrui
ref(useDecryptionWorkers): remove unused import
9f87471
@karrui
feat: return decryption state and show status toast after download
41caf29
@karrui
feat: enable responses download toast to be closed
3b91ae8
@karrui
refactor: rename and move DownloadResult type to common types
b33709b 
will be used by other modal progress screens soon
@karrui
feat: add CompleteScreen component when download has completed
109b9c5
@karrui
feat: show complete screen on download completion
1254024
@karrui
feat: add initial handling to show canceled state when canceling dl
c745fbb
@karrui
feat: add CanceledScreen component to show canceled state
fae41c5 
some changes from the design, since we do not save partial download state yet. This could come in future PRs.
@karrui
fix: set timeout for progress modal to show back to 5000
6133294 
set to 2000 for testing, forgot to change it back before committing.
@karrui
feat: add stories for success/cancelled states
c417d3f
@karrui karrui marked this pull request as ready for review July 13, 2022 08:16
timotheeg
timotheeg approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@timotheeg timotheeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

...admin-form/responses/ResponsesPage/storage/UnlockedResponses/ProgressModal/ProgressModal.tsx Show resolved Hide resolved
justynoh
justynoh reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@justynoh justynoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

frontend/src/features/admin-form/responses/ResponsesPage/storage/useDecryptionWorkers.ts Show resolved Hide resolved
@karrui karrui merged commit 012c09e into form-v2/develop Jul 20, 2022
@karrui karrui deleted the form-v2/storage-pause-complete-modal branch July 20, 2022 10:15
@karrui karrui mentioned this pull request Jul 21, 2022
Closed
This was referenced Oct 4, 2022
Closed
Merged
@justynoh justynoh mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justynoh justynoh justynoh left review comments

@timotheeg timotheeg timotheeg approved these changes

@tshuli tshuli Awaiting requested review from tshuli

@wanlingt wanlingt Awaiting requested review from wanlingt

@hanstirtaputra hanstirtaputra Awaiting requested review from hanstirtaputra

@siddarth2824 siddarth2824 Awaiting requested review from siddarth2824

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karrui @timotheeg @justynoh