feat(form-v2): show emergency contact popup in workspace page #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 8, 2022 11:29
…t modal from showing in chromatic
karrui
approved these changes
Jul 12, 2022
Comment on lines
+185
to
+188
| <EmergencyContactModal | ||
| onClose={() => setHasSeenEmergencyContact(true)} | ||
| isOpen={isEmergencyContactModalOpen} | ||
| /> |
There was a problem hiding this comment.
probably not the correct place to put this, since the modal will probably be instantiated in the admin header (when it is complete) (and it is also now when i realize that is why this feature is not in the app yet)
Add a TODO i guess, to move the auto-instantiation of the modal into the admin header when that is done?
There was a problem hiding this comment.
gotcha. and this is because we want it to appear whenever an admin logs in, not just the workspace page right? will create this as a separate issue
timotheeg
pushed a commit
that referenced
this pull request
Jul 17, 2022
* feat: add modal to workspacepage * test: add ViewedEmergencyContactDecorator to prevent emergency contact modal from showing in chromatic * fix: return null if user does not exist
5 tasks
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Emergency contact modal does not pop up on the workspace page
Working towards #4110
Somewhat blocked by #4006
Solution
Emergency contact modal pops up on the workspace page if the user does not have an existing emergency contact. This appears after the rollout announcement modal.
Breaking Changes
Features:
TODO: Clear
emergencyContactKeyin local storage upon logout, when the logout button is implemented (related to Issue [React] Admin Header component #4006 )Before & After Screenshots
AFTER:
Tests