feat(v2/end-page-builder-2) edit end page from builder #4047
Conversation
karrui
changed the base branch from
form-v2/develop
to
form-v2/feat/end-page-builder-1
|
|
||
| interface BuilderDrawerContainerProps { | ||
| title: string | ||
| content: JSX.Element |
There was a problem hiding this comment.
nit: probably can use react's children prop instead, then we can just inline the content instead of assigning it to the `contenq prop
There was a problem hiding this comment.
Got it, updated to use children prop
Yet to cleanup the TODO comments
hanstirtaputra
force-pushed
the
form-v2/feat/end-page-builder-2
branch
from
9e6407b to
191f7ef
Compare
| {stateData.state === BuildFieldState.EditingEndPage ? ( | ||
| <EndPageView /> | ||
| ) : ( | ||
| <FormBuilder placeholderProps={placeholderProps} /> | ||
| )} |
There was a problem hiding this comment.
instead of rendering between end page and builder view, should we just render both and hide them appropriately (by toggling display with display css prop)? This allows for the state and scroll position of either previews to be maintained
There was a problem hiding this comment.
Good idea, I've updated the PR to do that, thanks
| > | ||
| <Stack w="100%"> | ||
| <Flex justifyContent="center" pt="1rem" pb="0.5rem"> | ||
| <Image src={form?.admin?.agency?.logo ?? ''} h="4rem" /> |
There was a problem hiding this comment.
nit: do we need the empty string '' default? src accepts undefined
There was a problem hiding this comment.
Oh then we don't need '' default! Removed it
Builds on #3983
Problem
Second and last part of end page builder PR.
This PR adds the functionality to build the end/thank you page through the form builder
Closes #3361
Solution
Breaking Changes
Before & After Screenshots
Stories for
AdminFormPage/Createwill reflect the change