Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2/storage): add tests for CsvGenerator classes #3975

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Jun 9, 2022

Problem

Actually just moving them from AngularJS tests, to affirm that there are no changes in implementation.

Solution

Breaking Changes

  • No - this PR is backwards compatible

Improvements:

  • ref: move CsvGenerator and EncryptedResponseCsvGenerator to own dir

Tests

  • add tests for CsvGenerator and EncryptedResponseCsvGenerator classes.

@karrui karrui requested review from mantariksh and tshuli June 9, 2022 03:50
Copy link
Contributor

@mantariksh mantariksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wgt lgtm

@karrui karrui merged commit 7816b20 into form-v2/develop Jun 14, 2022
@karrui karrui deleted the form-v2/responses/add-csvgen-tests branch June 14, 2022 10:13
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants