Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v2/storage-4): add storage mode response download modals #3965

Merged
merged 19 commits into from
Jul 7, 2022
Merged

feat(v2/storage-4): add storage mode response download modals #3965

merged 19 commits into from
Jul 7, 2022

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Jun 7, 2022 •
edited
Loading

Problem

This PR adds storage mode response download modals.

TODOs to be done in future PRs (too keep this PR smaller):

  • add summary modal when download has completed, or errored.

Related to #3129

Solution

Breaking Changes

  • No - this PR is backwards compatible

Features:

  • progress modal will show up 5 seconds after download (if download is not yet complete) for non-attachment downloads
  • show confirmation modal on downloading responses with attachments, which will segue to progress modal
  • allow cancellation of decryption
  • add prompt when user attempts to leave the page
  • add Progress component theme

Before & After Screenshots

New stories have been added for DownloadWithAttachmentModal and ProgressModal component.

@karrui karrui force-pushed the form-v2/responses/download-stream-3 branch from 4a48a50 to 69d93b9 Compare June 9, 2022 02:36
Base automatically changed from form-v2/responses/download-stream-3 to form-v2/develop June 9, 2022 03:02
karrui added 10 commits June 9, 2022 11:03
@karrui
feat: add download modal when clicking download attachment
93e5c71
@karrui
feat: add callback for updating download progress
9c8c69b
@karrui
feat: add useBlocker and usePrompt hooks to prevent user navigation
5062068 
used to be in react-router but it was removed. able to add a custom hook to get the same behaviour back
@karrui
feat: add custom progress component theme
02cdd74 
used in download progress
@karrui
feat: add ProgressModal component to track download progress
0a70161
@karrui
feat: move mutation into hook, expose abortDecryption fn
b5ca2a9
@karrui
feat: trigger progress modal (after 5s) and handle cancel
c9c9938
@karrui
ref: rename DownloadModal to DownloadWithAttachmentModal with own dir
5142b01 
in prep for download attachment progress and modal page switching
@karrui
feat: make ProgressModal more reusable
ed677c7
@karrui
feat: move to attachment download progress content on attachment dl
c54ae4e
@karrui karrui force-pushed the form-v2/responses/download-modal-4 branch from a2f898b to c54ae4e Compare June 9, 2022 03:03
mantariksh
mantariksh approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@mantariksh mantariksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh getting increasingly hard to review in detail without writing code but generally lgtm

frontend/src/hooks/usePrompt.ts Show resolved Hide resolved
frontend/src/hooks/useBlocker.ts Show resolved Hide resolved
...src/features/admin-form/responses/ResponsesPage/storage/UnlockedResponses/DownloadButton.tsx Show resolved Hide resolved
...src/features/admin-form/responses/ResponsesPage/storage/UnlockedResponses/DownloadButton.tsx Show resolved Hide resolved
hanstirtaputra
hanstirtaputra reviewed Jun 15, 2022
View reviewed changes
Copy link
Contributor

@hanstirtaputra hanstirtaputra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally for downloading responses with attachments. Downloading the same responses in "CSV with attachments" results in the second download not progressing. Is this intended?

test-download-with-attachments.mov

...esPage/storage/UnlockedResponses/DownloadWithAttachmentModal/DownloadWithAttachmentModal.tsx Show resolved Hide resolved
@karrui
Copy link
Contributor Author

karrui commented Jun 16, 2022

Tested locally for downloading responses with attachments. Downloading the same responses in "CSV with attachments" results in the second download not progressing. Is this intended?

test-download-with-attachments.mov

Thanks for the catch! Will fix.

@karrui karrui mentioned this pull request Jun 16, 2022
Merged
@karrui karrui merged commit a86c53a into form-v2/develop Jul 7, 2022
@karrui karrui deleted the form-v2/responses/download-modal-4 branch July 7, 2022 02:40
This was referenced Oct 4, 2022
Closed
Merged
@justynoh justynoh mentioned this pull request Oct 5, 2022
Merged
@karrui karrui mentioned this pull request Nov 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanstirtaputra hanstirtaputra hanstirtaputra left review comments

@mantariksh mantariksh mantariksh approved these changes

@siddarth2824 siddarth2824 Awaiting requested review from siddarth2824

@tshuli tshuli Awaiting requested review from tshuli

@wanlingt wanlingt Awaiting requested review from wanlingt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karrui @hanstirtaputra @mantariksh