Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release 5.60.0 #3944

Merged
merged 5 commits into from
Jun 3, 2022
Merged

build: release 5.60.0 #3944

merged 5 commits into from
Jun 3, 2022

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Jun 2, 2022

Fixes

  • feat: rate limit for otp generation #3938
  • fix: server to randomize image and logo filenames before generating presigned url #3927

Dependency Updates

  • fix(deps): bump express-session from 1.17.2 to 1.17.3 #3923

dependabot bot and others added 5 commits May 31, 2022 13:47
Bumps [express-session](https://github.com/expressjs/session) from 1.17.2 to 1.17.3.
- [Release notes](https://github.com/expressjs/session/releases)
- [Changelog](https://github.com/expressjs/session/blob/master/HISTORY.md)
- [Commits](expressjs/session@v1.17.2...v1.17.3)

---
updated-dependencies:
- dependency-name: express-session
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
build: merge release 5.59.0 into develop
…resigned url (#3927)

* chore: update package-lock

* fix: backend to append random string in front of user-supplied fileid

* fix: frontend to use returned key to construct s3 url instead of client-supplied fileId

* chore: update tests

* chore: update frontend tests

* chore: tighten regex check for key returned
* feat: rate limit for otp generation

* chore: add rate limiting to deprecated otp endpoint

* build: empty commit

* chore: update docs
@tshuli
Copy link
Contributor Author

tshuli commented Jun 3, 2022

Tests

rate limit for otp generation

  • Create form with verified mobile field and test that verification SMSes still work

server to randomize image and logo filenames before generating presigned url

  • Create storage mode form. Test that logo and image upload works and can be displayed in public form.
  • (safety check, should not be affected by this PR) Add attachment field. Test that file upload works and can be retrieved from storage mode

@tshuli tshuli temporarily deployed to staging-al2 June 3, 2022 00:57 Inactive
@tshuli tshuli merged commit bdabac1 into release-al2 Jun 3, 2022
@tshuli tshuli deleted the release-5.60.0 branch June 3, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants