feat: log ip address on callback from twilio

[tshuli]

Problem

• Currently, we are unable to match the sender IP address to the twilio sms delivery report

Solution

• pass sender IP address to twilio as part of query param for callback

Tests

• Create form. Test that email and mobile field OTP verification and submission works
• Check that twilio webhooks contain sender IP address after OTP has been sent
• Check that admin contact number adding works normally

[hanstirtaputra]

LGTM

[mantariksh]

as discussed, would be better to pass the IP as a param to Twilio

[tshuli]

as discussed, would be better to pass the IP as a param to Twilio

Thanks! I changed the implementation to pass it as a query param in the callback

implementation changed

[karrui]

will need to fix tests

[tshuli]

Tests were failing because req.url contains only the relative path, and new URL() requires the absolute path (which has to be constructed using req.protocol + '://' + req.get('host') + req.originalUrl

Also added try catch block in case the URL constructor fails