perf(v2): improve responsiveness of public form when filling inputs (again) #3911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that component is split up so that input changes will not rerender the entire FormFields component leading to terrible performance.
karrui
changed the title
karrui
changed the title
tshuli
approved these changes
May 30, 2022
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR moves the form input watcher into PublicFormSubmitButton subcomponent so that input changes will not rerender the entire FormFields component leading to terrible performance.
This perf degradation was introduced in #3813.
Oddy reminiscent of #3576
Solution
Bug Fixes:
Before & After Screenshots
BEFORE:
AFTER:
