Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent webhook url from pointing to app subdomain #3903

Merged
merged 2 commits into from
May 30, 2022
Merged

fix: prevent webhook url from pointing to app subdomain #3903

merged 2 commits into from
May 30, 2022

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented May 25, 2022 •
edited
Loading

Closes #3902

Tests

  • Create storage mode form. Enter subdomain of app domain in webhook url. it should fail with the following message.

Screenshot 2022-05-25 at 9 29 20 PM

@tshuli tshuli temporarily deployed to staging-al2 May 25, 2022 13:07 Inactive
@tshuli tshuli merged commit 8b45e0e into develop May 30, 2022
@tshuli tshuli deleted the fix/webhook-subdomain-check branch May 30, 2022 10:04
@tshuli tshuli mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent webhook URLs from pointing to subdomains of app URL
2 participants
@tshuli @mantariksh