fix(v2): fix some uncaught a11y issues in public form, login page #3875
+21
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakraUI already adds the correct props when nested in a FormControl component. The htmlFor prop is actually the wrong id.
so label can still be used for aria-labelledby
karrui
changed the title
timotheeg
approved these changes
May 18, 2022
# Conflicts: # frontend/src/features/login/components/LoginForm.tsx
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes some a11y issues raised in design review of #3861 (chromatic link)
Solution
Bug Fixes:
Before & After Screenshots
Public form and login page stories should have (less) a11y violations