-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): add 404 screens for the application, update login page design #3871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
changed the title
feat(v2)Form v2/404 screens
feat(v2): add 404 screens for the application
May 17, 2022
3 tasks
mantariksh
approved these changes
May 30, 2022
public element already adds masthead
masthead will automatically show depending on whether page is public or not
karrui
changed the title
feat(v2): add 404 screens for the application
feat(v2): add 404 screens for the application, update login page design
Jun 6, 2022
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR adds the missing 404 screens for both invalid public form and forbidden pages.
Also updates login page to updated design, and remove govt mastheads on pages that were already covered by the
PublicElement
component.Related to #3439
Solution
Features:
Before & After Screenshots
New stories for above pages and screens added