Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): add 404 screens for the application, update login page design #3871

Merged
merged 21 commits into from
Jun 7, 2022

Conversation

karrui
Copy link
Contributor

@karrui karrui commented May 17, 2022

Problem

This PR adds the missing 404 screens for both invalid public form and forbidden pages.
Also updates login page to updated design, and remove govt mastheads on pages that were already covered by the PublicElement component.

Related to #3439

Solution

Features:

  • feat: add FormNotFound screen for public forms
  • feat: add NotFound404 page for invalid routes
  • feat: add AdminForbidden403 page for forbidden form admin routes

Before & After Screenshots

New stories for above pages and screens added

@karrui karrui changed the title feat(v2)Form v2/404 screens feat(v2): add 404 screens for the application May 17, 2022
frontend/.storybook/preview.tsx Outdated Show resolved Hide resolved
frontend/.storybook/preview.tsx Show resolved Hide resolved
@karrui karrui changed the title feat(v2): add 404 screens for the application feat(v2): add 404 screens for the application, update login page design Jun 6, 2022
@karrui karrui merged commit 68d9572 into form-v2/develop Jun 7, 2022
@karrui karrui deleted the form-v2/404-screens branch June 7, 2022 03:34
@karrui karrui mentioned this pull request Jun 23, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants