Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v2): add share form feature #3828

Merged
merged 9 commits into from
May 9, 2022
Merged

feat(v2): add share form feature #3828

merged 9 commits into from
May 9, 2022

Conversation

karrui
Copy link
Contributor

@karrui karrui commented May 4, 2022 •
edited
Loading

Problem

This PR adds the ability for admins to share their public form links
Closes #3827

Solution

Features:

  • Add share form feature, modal now opens on both workspace links and admin form navbar buttons.

Improvements:

  • ref(WorkspacePage): export disclosure directly instead of destructuring
  • feat: extract CopyButton to its own template component
  • allow InlineMessage to also accept ReactNode as children

Before & After Screenshots

New stories have been added for share form modal.

Deploy Notes

@karrui karrui requested review from timotheeg and tshuli May 4, 2022 09:26
timotheeg
timotheeg approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@timotheeg timotheeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

frontend/src/features/admin-form/share/ShareFormModal.tsx Show resolved Hide resolved
@karrui karrui merged commit b0c1e07 into form-v2/develop May 9, 2022
@karrui karrui deleted the form-v2/adminform/share-form branch May 9, 2022 08:09
This was referenced Oct 4, 2022
Closed
Merged
@justynoh justynoh mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeg timotheeg timotheeg approved these changes

@tshuli tshuli Awaiting requested review from tshuli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karrui @timotheeg