feat(v2/collab): render viewer-only collaborator modal #3793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
karrui
force-pushed
the
form-v2/feat/collab/transfer-ownership-1
branch
from
a84358b to
79f45f6
Compare
karrui
force-pushed
the
form-v2/feat/collab/view-only-2
branch
from
ce25775 to
b867d8f
Compare
Base automatically changed from
form-v2/feat/collab/transfer-ownership-1
to
form-v2/develop
April 26, 2022 10:26
karrui
force-pushed
the
form-v2/feat/collab/view-only-2
branch
from
b867d8f to
8a46bf7
Compare
|
|
use editability to selectively render the correct components
timotheeg
approved these changes
Apr 28, 2022
...s/admin-form/common/components/CollaboratorModal/CollaboratorListScreen/CollaboratorList.tsx
Outdated
Show resolved
Hide resolved
timotheeg
reviewed
Apr 28, 2022
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Form admin users with only view permissions to a particular form should see a different collaborator modal where they can not update other users' permissions as per design.
This PR adds that modal.
Related to #2487, will close when this entire chain is merged in.
Solution
Features:
ViewOnlyCollaboratormodal and its contents.Before & After Screenshots
New stories have been added for viewer only modal.