Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2/PublicForm): add handling of form color theme, update design #3774

Merged
merged 35 commits into from
Apr 26, 2022

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Apr 20, 2022

Problem

This PR implements handling of the current form's color theme and updates components to render their expected color theme. A couple of components have also been updated to accept theming of color.

Also update mobile and desktop styling to better fit design, most notably padding and the display of submission button.

Stories have been added for the various color themes and mobile views and snapshots should reflect those changes.

karrui added 23 commits April 21, 2022 00:04
@karrui karrui requested a review from timotheeg April 20, 2022 16:41
Copy link
Contributor

@timotheeg timotheeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@karrui karrui merged commit f3644df into form-v2/develop Apr 26, 2022
@karrui karrui deleted the form-v2/public-form-theme-colors branch April 26, 2022 06:37
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants