feat(v2): add admin form collaborator modal #3771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note that there is no checks for if the person has permissions, or if the collaborator to be removed is self
timotheeg
approved these changes
Apr 20, 2022
frontend/src/features/admin-form/common/components/CollaboratorModal/AddCollaboratorInput.tsx
Outdated
Show resolved
Hide resolved
frontend/src/features/admin-form/common/components/CollaboratorModal/AddCollaboratorInput.tsx
Outdated
Show resolved
Hide resolved
frontend/src/features/admin-form/common/components/CollaboratorModal/CollaboratorList.tsx
Outdated
Show resolved
Hide resolved
timotheeg
approved these changes
Apr 25, 2022
frontend/src/features/admin-form/common/components/CollaboratorModal/AddCollaboratorInput.tsx
Show resolved
Hide resolved
...nd/src/features/admin-form/common/components/CollaboratorModal/CollaboratorModal.stories.tsx
Show resolved
Hide resolved
4 tasks
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR adds the initial admin form collaboration feature, where admins can add/remove collaborators.
Note that there is still no transfer ownership feature, or viewer-only modal. Those will come in later PRs.
Meaning there are no client-side guards if a user with view-only rights attempts to modify collaborator permissions (backend will correctly block the action).
Related to #2487
Solution
Features:
useCollaboratorModalhook to control modal open closeBefore & After Screenshots
New stories in storybook