feat(ci/chromatic): fix node to v14 for turbosnap to work correctly #3763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chromatic is detecting package-lock changes and rerunning every single test instead of only running snapshot tests for changed stories. This is causing the costs to balloon with every push. This is a stopgap measure whilst Chromatic/we investigate a deeper cause. Tracked in chromaui/chromatic-cli#561
karrui
changed the title
This reverts commit 9361888.
timotheeg
approved these changes
Apr 18, 2022
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic is detecting package-lock changes and rerunning every single test instead of only running snapshot tests for changed stories due to
npm installusingnpm@7, resulting in diffs between the lockfileVersion of the repository's package-lock.json and the resulting package-lock.json in the workflow, triggering Turbosnap.This is causing the costs to balloon with every push. This PR adds a node version setting step to the workflow (to v14) so npm@6 is used to prevent any unnecessary lockfileVersion changes.