-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: conditional react routing #3750
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeg
force-pushed
the
form-v2/conditional_routing
branch
from
April 13, 2022 08:29
fbe880c
to
aade5b2
Compare
timotheeg
commented
Apr 13, 2022
timotheeg
commented
Apr 13, 2022
timotheeg
commented
Apr 13, 2022
timotheeg
commented
Apr 13, 2022
timotheeg
commented
Apr 13, 2022
I've fixed the Chromatic failure in #3751 |
timotheeg
force-pushed
the
form-v2/conditional_routing
branch
from
April 14, 2022 02:17
2b2147a
to
fb3993a
Compare
timotheeg
commented
Apr 14, 2022
@@ -61,6 +67,20 @@ const loggingMiddleware = () => { | |||
if (transactionId) { | |||
meta.transactionId = transactionId | |||
} | |||
|
|||
// Temporary: cookies are blacklisted, but we to track the state of the rollout for this particular request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// Temporary: cookies are blacklisted, but we to track the state of the rollout for this particular request | |
// Temporary: cookies are blacklisted, but we want to track the state of the rollout for this particular request |
karrui
approved these changes
Apr 14, 2022
timotheeg
force-pushed
the
form-v2/conditional_routing
branch
3 times, most recently
from
April 14, 2022 02:44
0ef6314
to
a0d2352
Compare
timotheeg
force-pushed
the
form-v2/conditional_routing
branch
from
April 14, 2022 03:03
a0d2352
to
a2732c0
Compare
timotheeg
force-pushed
the
form-v2/conditional_routing
branch
from
April 14, 2022 07:50
ecdd421
to
9d3f631
Compare
timotheeg
force-pushed
the
form-v2/conditional_routing
branch
from
April 19, 2022 05:25
9d3f631
to
fbd6d49
Compare
timotheeg
force-pushed
the
form-v2/conditional_routing
branch
from
April 19, 2022 06:02
fbd6d49
to
07a3e72
Compare
timotheeg
force-pushed
the
form-v2/conditional_routing
branch
from
April 21, 2022 07:34
67d747e
to
b44dbc5
Compare
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need a way to control rollout of React (and stop it if needed).
We have several constraints:
form.gov.sg
We considered several approach to do routing in infra, but the constraints above make it hard to do this outside application (which can have knowledge on admin/respondent and eligibility criteria based on form definitions.
Approach
formId
in URLreactMigrationController
/api/v3/admin/environment/(react|angular)
to allow setting of the cookie (only needed ifhttp-only
)TODOs / TODISCUSS
http-only
Deploy Notes
New environment variables:
REACT_MIGRATION_RESPONDENT_ROLLOUT
: number between 0 and 100REACT_MIGRATION_ADMIN_ROLLOUT
: number between 0 and 100