fix: update ports for maildev to 1080 and 1025 #3710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeg
changed the title
karrui
approved these changes
Apr 6, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
maildev has released a new docker image on 2022-03-30, which changed the internal app ports.
The smtp server now runs on port 1025 (was 25), the web interface runs in port 1080 (was 80). This was done on purpose in this PR.
This change in port causes the docker setup for FormSG to break since the app can't connect to the mail server, and so the ports need to be updated.
Approach
Update both the web app and smtp port for maildev.
The PR targets branch
develop, and we can mergedevelopintoform-v2/developlater.