-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create country field story #3705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
shared/constants/countries.ts
Outdated
@@ -0,0 +1,256 @@ | |||
export enum Country { | |||
AFGHANISTAN = 'AFGHANISTAN', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: keys should be SentenceCase, (values can remain as is)
e.g.
export enum Country {
Afghanistan = 'AFGHANISTAN',
...
}
PS: Probably don't need to manually do it, can probably do it in a javascript/node playground haha, by
- converting the enum into a
object
, - then running some sort of key-change function on the object, then
- JSONify the object,
- copy paste back into this enum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed by the latest commit 5d1da632a04966ad5c89153086406a78bca4f807
Problem
Partially solves #481
Solution
Dropdown
to create aCountryField
component in.stories
Breaking Changes
Before & After Screenshots
AFTER: