Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create country field story #3705

Merged
merged 8 commits into from
Apr 12, 2022

Conversation

jia1
Copy link
Member

@jia1 jia1 commented Apr 5, 2022

Problem

  • Create country field story

Partially solves #481

Solution

  • Rely on Dropdown to create a CountryField component in .stories

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Before & After Screenshots

AFTER:

Screenshot 2022-04-05 at 6 23 57 PM

@jia1 jia1 changed the base branch from develop to form-v2/develop April 5, 2022 09:17
@jia1 jia1 self-assigned this Apr 5, 2022
@jia1 jia1 changed the title feat: create country field feat: create country field story Apr 5, 2022
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -0,0 +1,256 @@
export enum Country {
AFGHANISTAN = 'AFGHANISTAN',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: keys should be SentenceCase, (values can remain as is)

e.g.

export enum Country {
  Afghanistan = 'AFGHANISTAN',
  ...
}

PS: Probably don't need to manually do it, can probably do it in a javascript/node playground haha, by

  1. converting the enum into a object,
  2. then running some sort of key-change function on the object, then
  3. JSONify the object,
  4. copy paste back into this enum

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed by the latest commit 5d1da632a04966ad5c89153086406a78bca4f807

@jia1 jia1 mentioned this pull request Apr 12, 2022
2 tasks
@karrui karrui merged commit 820720d into form-v2/develop Apr 12, 2022
@karrui karrui deleted the form-v2/create-country-field-story branch April 12, 2022 10:32
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants