feat: filter storage mode responses by submission id #362
Conversation
* feat: Filter Storage Mode Responses by Submission Id (updated 2020-09-13) * Update page design so that it is compatible with tablets and everything is on one row * Update CSS for iPad
There was a problem hiding this comment.
lgtm - could i trouble you to test this in staging to guarantee performance before merging, so that it definitely makes the next release? it's been languishing awhile.
FYI @frankchn, there was a bug with the conditional logic which meant we had to revert this PR during the release process. Return statements are booby traps when used in a callback pattern...
There was a problem hiding this comment.
minor comment on the logging format. I also think it might be worth the effort to extract some of this function into a service, or at least use async/await to make the control flow a little more obvious, but will defer to @liangyuanruo
|
fixed the log statement and tested on staging-alt, nothing unusual seems to be happening with the staging-alt db so I think we're good to go |
Fixes a bug with #174 for release. #174 was reverted in #358.